fix: prevent route crash when subscription or permissions prefetch fails #6047
Claude / Claude Code Review
completed
Apr 16, 2026 in 16m 27s
Code review found 3 potential issues
Found 4 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | frontend/src/pages/middlewares/inject-org-details.tsx:68-79 |
Promise.allSettled: silent rejection swallowing and inaccurate fallback comment |
Annotations
Check warning on line 79 in frontend/src/pages/middlewares/inject-org-details.tsx
claude / Claude Code Review
Promise.allSettled: silent rejection swallowing and inaccurate fallback comment
The `Promise.allSettled` result is never inspected, so rejections from `fetchOrgSubscription` or `fetchUserOrgPermissions` are completely silent — no logging, no alerting — despite an analogous `console.warn` already existing at line 58 for similar non-fatal failures. Additionally, the comment on lines 68–70 says these components use "useQuery hooks that will retry independently", but both `SubscriptionContext.tsx` and `OrgPermissionContext.tsx` actually use `useSuspenseQuery`, which throws to t
Loading