fix: correct base64 detection for ENCRYPTION_KEY#6036
Open
yb175 wants to merge 2 commits intoInfisical:mainfrom
Open
fix: correct base64 detection for ENCRYPTION_KEY#6036yb175 wants to merge 2 commits intoInfisical:mainfrom
yb175 wants to merge 2 commits intoInfisical:mainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b515dede5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Local development was failing with a
502 Bad Gatewayon/login. Backend logs revealed KMS initialization failing due toInvalid key length.The root cause: inverted logic when checking if
ENCRYPTION_KEYis base64-encoded. The condition!envConfig.ENCRYPTION_KEYwas treating a present key as missing, causing it to be decoded as UTF-8 instead of base64. This resulted in a 44-byte buffer instead of the required 32 bytes for AES-256-GCM.Fix
Changed the condition to
!!envConfig.ENCRYPTION_KEY, so base64-encoded keys are correctly decoded when present.Verification
/login502 Bad Gateway+Invalid key lengthin logs/loginloads successfullyType
Checklist