Skip to content

fix: exempt loopback from TierAuth so local vault run doesn't get 429'd #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangtony98 merged 2 commits into from
Apr 21, 2026
Merged

fix: exempt loopback from TierAuth so local vault run doesn't get 429'd #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2f2256
fix: exempt loopback from TierAuth so local vault run doesn't get 429'd
dangtony98 Apr 21, 2026
774b734
fix: drop over-broad loopback keyer; route unwrap alone covers vault run
dangtony98 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,14 +649,16 @@ func New(addr string, store Store, encKey []byte, notifier *notify.Notifier, ini
mux.HandleFunc("DELETE /v1/vaults/{name}/services/{host}", s.requireInitialized(s.requireAuth(actorAuthed(s.handleServiceRemove))))
mux.HandleFunc("DELETE /v1/vaults/{name}/services", s.requireInitialized(s.requireAuth(actorAuthed(s.handleServicesClear))))
mux.HandleFunc("GET /v1/vaults/{name}/services/credential-usage", s.requireInitialized(s.requireAuth(actorAuthed(s.handleServicesCredentialUsage))))
mux.HandleFunc("GET /v1/service-catalog", s.requireInitialized(ipAuth(s.handleServiceCatalog)))
mux.HandleFunc("GET /v1/skills/cli", s.requireInitialized(ipAuth(s.handleSkillCLI)))
mux.HandleFunc("GET /v1/skills/http", s.requireInitialized(ipAuth(s.handleSkillHTTP)))

// Public: transparent-proxy root CA. Safe to expose; clients need it to
// trust the minted leaves. Not wrapped in requireInitialized — the CA
// lifecycle is tied to --mitm-port, not owner registration.
mux.HandleFunc("GET /v1/mitm/ca.pem", ipAuth(s.handleMITMCA))
// Public static reads — immutable payloads with no credentials on
// the wire. TierGlobal is the only useful backstop; TierAuth would
// punish `vault run` (CA fetch per invocation) and the dashboard
// (re-mount poll) without defending any real surface.
mux.HandleFunc("GET /v1/service-catalog", s.requireInitialized(s.handleServiceCatalog))
mux.HandleFunc("GET /v1/skills/cli", s.requireInitialized(s.handleSkillCLI))
mux.HandleFunc("GET /v1/skills/http", s.requireInitialized(s.handleSkillHTTP))
// CA PEM is not wrapped in requireInitialized — the CA lifecycle is
// tied to --mitm-port, not owner registration.
mux.HandleFunc("GET /v1/mitm/ca.pem", s.handleMITMCA)

// Instance-level user invites
mux.HandleFunc("POST /v1/users/invites", s.requireInitialized(s.requireAuth(actorAuthed(limitBody(s.handleUserInviteCreate)))))
Expand Down