cli: rename --sandbox to --isolation for vault run#135
Merged
dangtony98 merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
Hard rename of `--sandbox=process|container` to `--isolation=host|container` (env: `AGENT_VAULT_SANDBOX` -> `AGENT_VAULT_ISOLATION`). Default behavior unchanged; no aliases. `host` replaces `process` because the only boundary in that mode is the agent honoring HTTPS_PROXY -- naming it `host` makes the "no isolation" tradeoff visible. Future modes (Lima VM, devcontainers) will fit `--isolation` more cleanly than `--sandbox`. Touches the flag definition, internal package (internal/sandbox -> internal/ isolation), embedded docker image repo, host CA dir, network label, both agent skill files, and all docs (README, .env.example, CLI reference, env var reference, container-sandbox.mdx -> container-isolation.mdx, docs.json nav). CLAUDE.md updated to reflect new names. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
💬 Discussion in Slack: #pr-review-agent-vault-135-cli-rename-sandbox-to-isolation-for-vault-run Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hard rename of
--sandbox=process|containerto--isolation=host|containerforvault run, plus the matching env var (AGENT_VAULT_SANDBOX→AGENT_VAULT_ISOLATION) and internal package (internal/sandbox→internal/isolation).hostoverprocess: today's "process" mode has no actual process isolation — the only boundary is the agent honoringHTTPS_PROXY. Naming ithostmakes the "no isolation" tradeoff visible and nudges users towardcontainerwhen they want a real boundary. Also more accurate when future modes (Lima, devcontainers) land — those run in a VM/container from the host's perspective.--sandboxandAGENT_VAULT_SANDBOXare removed, not deprecated. Pre-1.0, the cost of a deprecation cycle outweighs the small user impact.Surfaces touched
cmd/sandbox_flag.go→cmd/isolation_flag.go(SandboxMode/Process/Container→IsolationMode/Host/Container);internal/sandbox/→internal/isolation/with embed var, image-repo string (agent-vault/sandbox→agent-vault/isolation), host CA dir (~/.agent-vault/sandbox/→~/.agent-vault/isolation/), and network label (agent-vault-sandbox→agent-vault-isolation) all renamed for consistency. Test files renamed:internal/{mitm,ca}/sandbox_*_test.go→isolation_*_test.go.CLAUDE.md):cmd/skill_cli.md,cmd/skill_http.md.README.md,.env.example,docs/reference/cli.mdx,docs/self-hosting/environment-variables.mdx. Renameddocs/guides/container-sandbox.mdx→docs/guides/container-isolation.mdx; updateddocs/docs.jsonnav.CLAUDE.md"Two isolation modes" bullet rewritten..github/dependabot.ymldocker directory path.One-time user impact
vault run --isolation=containeruse (image is hash-tagged so the oldagent-vault/sandbox:*orphans).~/.agent-vault/sandbox/dir from prior runs becomes orphaned (tiny PEM files; safe torm -rf).agent-vault-sandbox-labeled networks from previously-crashed runs won't be auto-pruned.All acceptable for a pre-1.0 hard rename; the plan accepted these explicitly.
Test plan
go build ./...— cleango test ./...— all green (asset hash pin updated for the Dockerfile comment edit)vault run --helpshows--isolation(defaulthost);--sandboxabsentvault run --sandbox=processrejected withunknown flag: --sandboxAGENT_VAULT_SANDBOX|--sandbox|SandboxMode|SandboxProcess|SandboxContainer|internal/sandbox|/guides/container-sandboxreturns zero hitsdocs/guides/container-isolation.mdxand the nav entryfeat(sandbox): extend --share-agent-dir) against this — its title and any flag references need updatingOut of scope
docs/guides/smtp.mdx(unrelated).README.mdanddocs/quickstart/custom-agent.mdx(describes external runtimes like Daytona/E2B/Firecracker, not Agent Vault's flag).docs/agents/overview.mdxanddocs/guides/connect-coding-agent.mdx(still reads accurately for the defaulthostmode).🤖 Generated with Claude Code