Test 45782: Prevent manual scoring of unfinished attempts#11509
Open
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
Test 45782: Prevent manual scoring of unfinished attempts#11509matheuszych wants to merge 1 commit intoILIAS-eLearning:release_10from
matheuszych wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
See: https://mantis.ilias.de/view.php?id=45782 Manual scoring by question allowed opening the scoring UI for attempts that were still in progress. `ScoringByQuestionTableBinder` now skips unfinished attempts when composing table rows. `TestScoringByQuestionGUI` verifies the attempt is finished via `getAttemptOverviewFor` before calling `getAnswerDetail`; otherwise an exception is thrown.
matheuszych
changed the title
Contributor
|
@kergomard please review! |
|
Possibly I am just mistaken – but I fail to see the direct connection of this PR to the mentioned issue, implied by the Mantis link. 🤔 (... just in case this remark has any relevance at all 😉) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://mantis.ilias.de/view.php?id=45782
Manual scoring by question allowed opening the scoring UI for attempts that were still in progress.
ScoringByQuestionTableBindernow skips unfinished attempts when composing table rows.TestScoringByQuestionGUIverifies the attempt is finished viagetAttemptOverviewForbefore callinggetAnswerDetail; otherwise an exception is thrown./cc @thojou