Test: Rename variable for ass logging#11495
Test: Rename variable for ass logging#11495mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_9from
Conversation
|
Hi @mjansenDatabay, thanks for your PR. Kind regards |
|
Hi @dsstrassner , we would highly appreciate a review by the authorities. Afterwards we, as TB, would take over the merge into release_9. This fix is a cherry-pick from ILIAS 8 btw. For the Technical Board of the ILIAS Society |
kergomard
left a comment
There was a problem hiding this comment.
Hi all
I looked at the changes and they look correct and I do not see any problem with it.
I explicitly do not approve this PR as I will not take any responsibility for any regressions caused on a security only branch by introducing fixes that have nothing to do with security.
Best,
@kergomard
This PR suggests picking a commit from
release_8to solve Mantis Issue https://mantis.ilias.de/view.php?id=47705 .The original fix cleaned up variable naming when creating logging entries in the test component. Unfortunately, during the great PHP 8 compliance campaign of ILIAS 8, this tiny but noble commit apparently became collateral damage somewhere between strict types, deprecated warnings, and existential null checks.
The variables have now safely returned from the battlefield and are once again reporting for logging duty in
release_9.