Skip to content

Test: Rename variable for ass logging#11495

Open
mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_9from
mjansenDatabay:hotfix/9/47705
Open

Test: Rename variable for ass logging#11495
mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_9from
mjansenDatabay:hotfix/9/47705

Conversation

@mjansenDatabay
Copy link
Copy Markdown
Contributor

@mjansenDatabay mjansenDatabay commented Apr 29, 2026

This PR suggests picking a commit from release_8 to solve Mantis Issue https://mantis.ilias.de/view.php?id=47705 .

The original fix cleaned up variable naming when creating logging entries in the test component. Unfortunately, during the great PHP 8 compliance campaign of ILIAS 8, this tiny but noble commit apparently became collateral damage somewhere between strict types, deprecated warnings, and existential null checks.

The variables have now safely returned from the battlefield and are once again reporting for logging duty in release_9.

@mjansenDatabay mjansenDatabay added bugfix php Pull requests that update Php code labels Apr 29, 2026
@dsstrassner
Copy link
Copy Markdown
Contributor

Hi @mjansenDatabay,

thanks for your PR.
@ILIAS-eLearning/technical-board We (as in T&A code authorities) will review this PR if the TB agrees to merge this into ILIAS 9. I hope this doesn't open a can of worms. Because it's not really a security fix.

Kind regards

@dsstrassner

@rfalkenstein
Copy link
Copy Markdown
Contributor

Hi @dsstrassner , we would highly appreciate a review by the authorities. Afterwards we, as TB, would take over the merge into release_9. This fix is a cherry-pick from ILIAS 8 btw.
Thanks for the immediate reaction!
Best regards,
@rfalkenstein

For the Technical Board of the ILIAS Society

Copy link
Copy Markdown
Contributor

@kergomard kergomard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all

I looked at the changes and they look correct and I do not see any problem with it.

I explicitly do not approve this PR as I will not take any responsibility for any regressions caused on a security only branch by introducing fixes that have nothing to do with security.

Best,
@kergomard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code technical board

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants