TestQuestionPool 47194: Fix LongMenuQuestion Answers Modal#11489
Open
thojou wants to merge 1 commit intoILIAS-eLearning:release_11from
Open
TestQuestionPool 47194: Fix LongMenuQuestion Answers Modal#11489thojou wants to merge 1 commit intoILIAS-eLearning:release_11from
thojou wants to merge 1 commit intoILIAS-eLearning:release_11from
Conversation
See https://mantis.ilias.de/view.php?id=47194 The LongMenuQuestion points correction rendered the lightbox modal inside the surrounding property form. Since the lightbox close button uses its own dialog form, this produced invalid nested form markup and caused browsers to repair the DOM differently for the first and following modals. This moves the answers modal out of the parent form via `getContentOutsideFormTag()` while keeping the show button in the correction input markup.
thojou
force-pushed
the
bugfix/11/47194-long-menu-answers-modal
branch
from
8baf84a to
b984c47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://mantis.ilias.de/view.php?id=47194
The LongMenuQuestion points correction rendered the lightbox modal inside the surrounding property form. Since the lightbox close button uses its own dialog form, this produced invalid nested form markup and caused browsers to repair the DOM differently for the first and following modals. This moves the answers modal out of the parent form via
getContentOutsideFormTag()while keeping the show button in the correction input markup.