References: make type match ref_id and obj_id in list GUIs (47391)#11478
Open
schmitz-ilias wants to merge 1 commit intoILIAS-eLearning:trunkfrom
Open
References: make type match ref_id and obj_id in list GUIs (47391)#11478schmitz-ilias wants to merge 1 commit intoILIAS-eLearning:trunkfrom
schmitz-ilias wants to merge 1 commit intoILIAS-eLearning:trunkfrom
Conversation
Contributor
|
Thank you very much for the PR @schmitz-ilias ! I would propose for you not to use this approach as this comes at a very high prize: References would not tell the truth about their type in lists. I'm completely sure that will bite you in the behind later on. I would suggest for you to override Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 47391 by making sure that
ilObjectListGUI::$ref_id,ilObjectListGUI::$obj_idandilObjectListGUI::$typeof container references match. This seems a bit of a risky change,ilObjectListGUI::$typeshows up a lot inilObjectListGUI, see the ticket for details.@kergomard, there are no code changes in your components, but this PR mainly concerns how an "interface" of your component should be used, so as far as I'm concerned this is your call to make. Let me know how you want to proceed with this and 47391, I can take of merging and whatnot.
@maalers, you should also have quick look here,
ilObjStudyProgrammeReferenceListGUIis also affected. If you have any doubts or questions, let me know!