DEP: Add emergency api endpoint#2723
Draft
sudip-khanal wants to merge 4 commits intoproject/dref-emergency-pagesfrom
Draft
DEP: Add emergency api endpoint#2723sudip-khanal wants to merge 4 commits intoproject/dref-emergency-pagesfrom
sudip-khanal wants to merge 4 commits intoproject/dref-emergency-pagesfrom
Conversation
- Add Enum for event sources. - Add source field in place of auto generated source field on event model. - Migrate existing event records to enum type. - Update related serializers and tests.
- Add new emergency api for. - Attach latest field report. - Add test case for emergency endpoint.
susilnem
requested changes
Apr 28, 2026
| class Event(models.Model): | ||
| """A disaster, which could cover multiple countries""" | ||
|
|
||
| class EventSources(models.IntegerChoices): |
Member
There was a problem hiding this comment.
Suggested change
| class EventSources(models.IntegerChoices): | |
| class EventSource(models.IntegerChoices): |
| auto_generated_source = models.CharField( | ||
| verbose_name=_("auto generated source"), max_length=50, null=True, blank=True, editable=False | ||
| ) | ||
| source = models.IntegerField(choices=EventSources.choices, default=EventSources.Manual_Input, verbose_name=_("Event source")) |
Member
There was a problem hiding this comment.
Suggested change
| source = models.IntegerField(choices=EventSources.choices, default=EventSources.Manual_Input, verbose_name=_("Event source")) | |
| source = models.IntegerField(choices=EventSource.choices, default=EventSource.Manual_Input, verbose_name=_("Event source")) |
| disaster_start_date=report.start_date, | ||
| auto_generated=True, | ||
| auto_generated_source=SOURCES["new_report"], | ||
| source=Event.EventSources.NEW_REPORT, |
Member
There was a problem hiding this comment.
Suggested change
| source=Event.EventSources.NEW_REPORT, | |
| source=Event.EventSource.NEW_REPORT, |
| return CountrySupportingPartner.objects.select_related("country") | ||
|
|
||
|
|
||
| class EmergencyViewset(viewsets.ReadOnlyModelViewSet): |
Member
There was a problem hiding this comment.
We might need to use the ReadOnlyVisibilityViewset class, same as EventViewset.
Comment on lines
+1549
to
+1551
| class EmergencyViewset(viewsets.ReadOnlyModelViewSet): | ||
|
|
||
| queryset = Event.objects.all() |
Member
There was a problem hiding this comment.
Suggested change
| class EmergencyViewset(viewsets.ReadOnlyModelViewSet): | |
| queryset = Event.objects.all() | |
| class EmergencyViewset(viewsets.ReadOnlyModelViewSet): | |
| queryset = Event.objects.all() |
Comment on lines
+1572
to
+1574
| latest_field_report_id=Subquery( | ||
| FieldReport.objects.filter(event=OuterRef("pk")).order_by("-created_at").values("id")[:1] | ||
| ), |
Member
There was a problem hiding this comment.
We need to filter this out from the Field Report number.
Line 2304 in e96df48
Comment on lines
+1575
to
+1576
| appeal_id=Subquery(Appeal.objects.filter(event=OuterRef("pk")).order_by("-created_at").values("id")[:1]), | ||
| ) |
Member
There was a problem hiding this comment.
Check this logic against how it was done in the frontend before. @shreeyash07
| class EventSources(models.IntegerChoices): | ||
|
|
||
| Manual_Input = 100, _("Manual input") | ||
| """MANUAL_INPUT: Event data manually entered by a user through the event administration interface.""" |
Member
There was a problem hiding this comment.
Suggested change
| """MANUAL_INPUT: Event data manually entered by a user through the event administration interface.""" | |
| """MANUAL_INPUT: Event data manually entered by a user through the event administration interface.""" |
| DREF = 170, _("DREF") | ||
| """DREF: Event originating records.""" | ||
|
|
||
| Unknown = 180, _("Unknown") |
Member
There was a problem hiding this comment.
This case should not occur. If there is existing data, we may need to populate it other source but now unknown.
Comment on lines
+2613
to
+2614
| latest_field_report_id = serializers.IntegerField(read_only=True) | ||
| appeal_id = serializers.IntegerField(read_only=True) |
Member
There was a problem hiding this comment.
Suggested change
| latest_field_report_id = serializers.IntegerField(read_only=True) | |
| appeal_id = serializers.IntegerField(read_only=True) | |
| # NOTE: Populated from Queryset using Annotate | |
| latest_field_report_id = serializers.IntegerField(read_only=True) | |
| appeal_id = serializers.IntegerField(read_only=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.