Draft
Conversation
susilnem
force-pushed
the
project/eap-workflow
branch
from
ebe7199 to
2a7be37
Compare
susilnem
force-pushed
the
project/eap-workflow
branch
3 times, most recently
from
5c91d42 to
a685718
Compare
susilnem
force-pushed
the
project/eap-workflow
branch
2 times, most recently
from
e5b2cc4 to
8b87dc0
Compare
frozenhelium
force-pushed
the
project/eap-workflow
branch
from
6ba92e5 to
75caa5a
Compare
susilnem
force-pushed
the
project/eap-workflow
branch
from
8402701 to
06d934d
Compare
szabozoltan69
force-pushed
the
develop
branch
from
c139ea6 to
fe50eaf
Compare
susilnem
force-pushed
the
project/eap-workflow
branch
from
06d934d to
4f4b133
Compare
szabozoltan69
force-pushed
the
develop
branch
from
58d3da6 to
3ffba0d
Compare
- Add Serializer, filterset - Admin setup, router for eap development-registration
- Add factories - Add eap file endpoint - Add update status endpoint
- Update test cases - Add EAPBaseViewSet - Update on BaseEAPSerializer
- Update test cases - Add validations on SimplifiedEAP - Add update validations check on registrations
- Add test cases - Update additional typing - Add Permissions for country admin and IFRC admin users on eap
- Update test cases - Add validation checks on status transition - Add new endpoint for uploading validated budget file
- Add file validation checks - Add status transition file checks
- Optimise and add fields on admin panel - Update test cases for snapshot - Add utility function to clone the related model
Update full eap form validation
- Change eap global export file url
- Update pending-PFA email template to link the auto-generated diff and summary PDFs - Generate summary or diff pdf file if missing
- remove required fields for eap model - add validation checks step on status transition to under review
Eap: Add diff PDF file to pending-PFA email attachment
- changes on enums - add sourceinformation for meal and ns capacity
- add new fields lead_timeframe_unit - change pending pfa to approved(pending pfa)
- Update admin panel - Add test for edge cases
susilnem
force-pushed
the
project/eap-workflow
branch
from
56c61f3 to
ce3564d
Compare
szabozoltan69
force-pushed
the
develop
branch
2 times, most recently
from
3ec10a5 to
8923dcf
Compare
- Update export and diff file generation logic - Add validation check for time value - Update on utils email context - update test cases for notifications - add ns contact title on email and dev preview
EAP/ Update email contents and Exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.