Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Homebrew cask for Voicemod version 1.6.6, enabling installation via a .pkg installer and defining uninstall/zap cleanup behavior.
Changes:
- Introduces
Casks/v/voicemod.rbwith versioned download URL and SHA256. - Adds
pkg,uninstall, andzapstanzas for installation and removal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5df465d to
bdb002a
Compare
2ec07a5 to
8a02f79
Compare
|
I have implemented strategy :header_match for the livecheck block. Since the Voicemod website uses dynamic redirects and the Sparkle feeds are not currently publicly indexed, I verified via curl that the flagship-versions server correctly returns versioned filenames (e.g., Voicemod_1.6.6-Intel.pkg). This should allow Homebrew to track future updates successfully. I also updated the cask to use the arch stanza and corrected all brew style offenses. |
cce5725 to
441fc2b
Compare
|
@sammykramer Please stop ignoring the review comments or I will need to close the PR because it is not a good use of maintainer resources. |
|
I apologize for the confusion. I was attempting to handle the version mismatch with a local variable, but I have now updated the Cask to use the standard Homebrew comma-separated versioning (3.5.16,1.6.6) so that #{version} logic is preserved in the URL and PKG stanzas. Thank you for your patience as I learn the contribution guidelines. |
|
As I have mentioned in a couple of comments, we only need to capture the |
|
I apologize for the back-and-forth. I've been learning the Homebrew contribution workflow and appreciate the time you took to review. I have the final version with the hardcoded launcher version and 3.5.16 app version ready in my local branch if it's ever needed. Thanks again! |
|
@sammykramer The PR was closed because you continued to ignore PR review comments throughout the process, and I suspect that you used AI to make the changes throughout (including reading the review comments), if this isn't the case please correct me. If anyone comes back to this later, the launcher version is entirely irrelevant here as I have mentioned multiple times, the in-app updater points to a full installer with the apps actual version |
|
I appreciate the feedback. To clarify, I was reading all your comments and trying to follow them, but as a student still learning Ruby and Homebrew's rules, I’ve been using an AI to help me understand the complicated parts of your messages. I wasn't trying to ignore you I was just having trouble to translate the feedback into the code correctly. Thanks for the API links and the guidance because I have learned a lot. |
|
@sammykramer I have left three suggestions above that should prepare this to be ready for merge. I'll reopen this PR to let you apply them. I can see where this application specifically is a bit confusing, because the version presented on the Voicemod website gives you a different version to what the application itself updates to in the application. The changes align the cask with what the application itself will automatically update you to. |
b32f1e9 to
d490c9a
Compare
|
Thank you @sammykramer |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.If AI was used to generate or assist with generating the PR:
zapstanza paths.I used Gemini to help draft the initial Ruby DSL structure, specifically the pkg and uninstall stanzas required for the .pkg installer. I manually verified the SHA256 checksum, tested the installation and uninstallation locally, and verified the zap paths in my Library folder.