Skip to content

voicemod 1.6.6 (new cask)#254099

Merged
bevanjkay merged 3 commits intoHomebrew:mainfrom
sammykramer:add-voicemod-1-6-6
Mar 16, 2026
Merged

voicemod 1.6.6 (new cask)#254099
bevanjkay merged 3 commits intoHomebrew:mainfrom
sammykramer:add-voicemod-1-6-6

Conversation

@sammykramer
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • [ x] Named the cask according to the token reference.
  • [x ] Checked the cask was not already refused (add your cask's name to the end of the search field).
  • [ x] brew audit --cask --new <cask> worked successfully.
  • [ x] HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • [ x] brew uninstall --cask <cask> worked successfully.

If AI was used to generate or assist with generating the PR:

  • [ x] I used AI to generate or assist with generating this PR. Please specify below how you used AI to help you.
  • [ x] I have personally reviewed, tested and verified all changes/additions, including zap stanza paths.

I used Gemini to help draft the initial Ruby DSL structure, specifically the pkg and uninstall stanzas required for the .pkg installer. I manually verified the SHA256 checksum, tested the installation and uninstallation locally, and verified the zap paths in my Library folder.

Copilot AI review requested due to automatic review settings March 16, 2026 02:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Homebrew cask for Voicemod version 1.6.6, enabling installation via a .pkg installer and defining uninstall/zap cleanup behavior.

Changes:

  • Introduces Casks/v/voicemod.rb with versioned download URL and SHA256.
  • Adds pkg, uninstall, and zap stanzas for installation and removal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sammykramer sammykramer force-pushed the add-voicemod-1-6-6 branch 2 times, most recently from 5df465d to bdb002a Compare March 16, 2026 02:55
@khipp khipp changed the title Add voicemod 1.6.6 voicemod 1.6.6 (new cask) Mar 16, 2026
khipp
khipp previously approved these changes Mar 16, 2026
@khipp khipp dismissed their stale review March 16, 2026 03:35

Casks is missing working a livecheck

@sammykramer
Copy link
Contributor Author

I have implemented strategy :header_match for the livecheck block. Since the Voicemod website uses dynamic redirects and the Sparkle feeds are not currently publicly indexed, I verified via curl that the flagship-versions server correctly returns versioned filenames (e.g., Voicemod_1.6.6-Intel.pkg). This should allow Homebrew to track future updates successfully.

I also updated the cask to use the arch stanza and corrected all brew style offenses.

@bevanjkay
Copy link
Member

@sammykramer Please stop ignoring the review comments or I will need to close the PR because it is not a good use of maintainer resources.

@sammykramer
Copy link
Contributor Author

I apologize for the confusion. I was attempting to handle the version mismatch with a local variable, but I have now updated the Cask to use the standard Homebrew comma-separated versioning (3.5.16,1.6.6) so that #{version} logic is preserved in the URL and PKG stanzas. Thank you for your patience as I learn the contribution guidelines.

@bevanjkay
Copy link
Member

As I have mentioned in a couple of comments, we only need to capture the 3.5.16 version, the other version is not relevant.

@bevanjkay bevanjkay closed this Mar 16, 2026
@sammykramer
Copy link
Contributor Author

I apologize for the back-and-forth. I've been learning the Homebrew contribution workflow and appreciate the time you took to review. I have the final version with the hardcoded launcher version and 3.5.16 app version ready in my local branch if it's ever needed. Thanks again!

@bevanjkay
Copy link
Member

bevanjkay commented Mar 16, 2026

@sammykramer The PR was closed because you continued to ignore PR review comments throughout the process, and I suspect that you used AI to make the changes throughout (including reading the review comments), if this isn't the case please correct me.

If anyone comes back to this later, the launcher version is entirely irrelevant here as I have mentioned multiple times, the in-app updater points to a full installer with the apps actual version 3.5.16 - API feed: https://api.voicemod.net/v1/nextgen/update/{} | Appcast: https://flagship-versions.voicemod.net/3.15.6/Voicemod-3.15.6-AppleSilicon.xml

@sammykramer
Copy link
Contributor Author

I appreciate the feedback. To clarify, I was reading all your comments and trying to follow them, but as a student still learning Ruby and Homebrew's rules, I’ve been using an AI to help me understand the complicated parts of your messages. I wasn't trying to ignore you I was just having trouble to translate the feedback into the code correctly. Thanks for the API links and the guidance because I have learned a lot.

@bevanjkay
Copy link
Member

@sammykramer I have left three suggestions above that should prepare this to be ready for merge. I'll reopen this PR to let you apply them. I can see where this application specifically is a bit confusing, because the version presented on the Voicemod website gives you a different version to what the application itself updates to in the application. The changes align the cask with what the application itself will automatically update you to.

@bevanjkay bevanjkay reopened this Mar 16, 2026
@bevanjkay bevanjkay added this pull request to the merge queue Mar 16, 2026
Merged via the queue into Homebrew:main with commit ec28af2 Mar 16, 2026
15 checks passed
@sammykramer sammykramer deleted the add-voicemod-1-6-6 branch March 16, 2026 21:14
@bevanjkay
Copy link
Member

Thank you @sammykramer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants