Fix game filters not applying#367
Merged
Geokureli merged 2 commits intoHaxeFlixel:devfrom Nov 24, 2024
ACrazyTown:fix/game-filters
Merged
Fix game filters not applying#367Geokureli merged 2 commits intoHaxeFlixel:devfrom ACrazyTown:fix/game-filters
Geokureli merged 2 commits intoHaxeFlixel:devfrom
ACrazyTown:fix/game-filters
Conversation
Member
|
So previously we were setting it directly, here. If this is bad practice we should take it out and maybe find a way to throw a warning in flixel |
Member
|
I created HaxeFlixel/flixel#3293 |
Geokureli
requested changes
Nov 24, 2024
Geokureli
approved these changes
Nov 24, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlxGame filters need to be set via the
setFilters()function otherwise they'll get overwritten in update