Support downloading pre-built theory files from an online Holmake cache#1891
Draft
mrichards30 wants to merge 11 commits intoHOL-Theorem-Prover:developfrom
Draft
Support downloading pre-built theory files from an online Holmake cache#1891mrichards30 wants to merge 11 commits intoHOL-Theorem-Prover:developfrom
mrichards30 wants to merge 11 commits intoHOL-Theorem-Prover:developfrom
Conversation
mark as cache miss and move on if the attempt at connecting goes past 5 seconds
Member
|
This is relevant to #1531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds support for downloading pre-built theory files for Holmake using
--cache-url <url>,e.g.
Holmake --cache-url http://localhost:8080orHolmake fooTheory --cache-url http://localhost:8080.Servers should implement the following specification holmake-cache-server.yaml. This can be viewed through the Swagger editor.
The cachekey feature has also been refactored a little bit. Previously its logic was tied into the
--cachekeyCLI, but I needed a string-producing version. Its tests still pass.