feat(SDK-553): add PolicyList functional component#1413
Draft
krisxcrash wants to merge 8 commits intokw/feat/sdk-551-policy-list-storiesfrom
Draft
feat(SDK-553): add PolicyList functional component#1413krisxcrash wants to merge 8 commits intokw/feat/sdk-551-policy-list-storiesfrom
krisxcrash wants to merge 8 commits intokw/feat/sdk-551-policy-list-storiesfrom
Conversation
Stateless presentation component for the time off policy list. Renders a DataView table with Name/Enrolled columns, per-row overflow menu (Edit/Delete), Finish setup button for incomplete policies, delete confirmation dialog, dismissible success alert, and empty state. Also updates translations to match Figma designs. Made-with: Cursor
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
Made-with: Cursor
Stories covering all visual states: default (with incomplete policy), empty state, post-delete success alert, and deleting-in-progress. Made-with: Cursor
krisxcrash
force-pushed
the
kw/feat/sdk-551-policy-list-stories
branch
from
bb138f7 to
f1a509f
Compare
Wire up data fetching and event handling for the time off policy list. Fetches policies via useTimeOffPoliciesGetAllSuspense, handles delete via useTimeOffPoliciesDeactivateMutation with query invalidation, and fires state machine events with policyId/policyType payloads for navigation to detail screens. Made-with: Cursor
Made-with: Cursor
krisxcrash
force-pushed
the
kw/feat/sdk-553-policy-list-functional
branch
from
a4110ff to
8a68f32
Compare
krisxcrash
force-pushed
the
kw/feat/sdk-551-policy-list-stories
branch
2 times, most recently
from
8374d6f to
4125b65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PolicyList.tsxwith a fully wired functional componentindex.tsfor the PolicyList directoryChanges
BaseComponent+Rootpattern; fetches policies viauseTimeOffPoliciesGetAllSuspense, handles delete viauseTimeOffPoliciesDeactivateMutationwithinvalidateAllTimeOffPoliciesGetAll, maps API data toPolicyListItem[], fires state machine events with{ policyId, policyType }payloadsPolicyList,PolicyListPresentation, and typesRelated
Testing
npx tsc --noEmitpasses with no errors