WIP feat: add optional header prop to Box component#1408
Draft
aaronlee777 wants to merge 1 commit intomainfrom
Draft
WIP feat: add optional header prop to Box component#1408aaronlee777 wants to merge 1 commit intomainfrom
aaronlee777 wants to merge 1 commit intomainfrom
Conversation
Add header support mirroring the existing footer pattern, with border-bottom separator and consistent padding. Box remains usable with no header/footer, header only, footer only, or both. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aaronlee777
changed the title
jeffredodd
reviewed
Mar 30, 2026
| import { type BoxProps } from '@/components/Common/UI/Box/BoxTypes' | ||
|
|
||
| export function Box({ children, footer, className }: BoxProps) { | ||
| export function Box({ children, header, footer, className }: BoxProps) { |
Contributor
There was a problem hiding this comment.
Isn't a box with a header and footer a card?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add header support mirroring the existing footer pattern, with border-bottom separator and consistent padding. Box remains usable with no header/footer, header only, footer only, or both.
Demo