Skip to content

chore: wrap standalone runtime with trait#8083

Draft
shuiyisong wants to merge 2 commits intoGreptimeTeam:mainfrom
shuiyisong:chore/standalone_startup
Draft

chore: wrap standalone runtime with trait#8083
shuiyisong wants to merge 2 commits intoGreptimeTeam:mainfrom
shuiyisong:chore/standalone_startup

Conversation

@shuiyisong
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Signed-off-by: shuiyisong <xixing.sys@gmail.com>
@github-actions github-actions Bot added size/S docs-not-required This change does not impact docs. labels May 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a StandaloneLeaderServicesController trait to manage the startup and shutdown of services like the procedure manager and WAL provider in standalone mode. It also adds an open_regions_writable_override option to InstanceCreator and DatanodeBuilder, allowing for explicit control over whether regions are opened as writable during startup. Additionally, several creator traits were updated with Send + Sync bounds, and new customization methods were added to InstanceCreator. I have no feedback to provide as there were no review comments.

Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant