fix: type inference for sql rewrite#8052
Open
sunng87 wants to merge 1 commit intoGreptimeTeam:mainfrom
Open
Conversation
sunng87
requested review from
a team,
discord9,
evenyag and
waynexia
as code owners
github-actions
Bot
added
size/XS
docs-not-required
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the SQL planner to correctly infer parameter types from arrow_cast expressions, which are typically generated during explicit type casting (e.g., $1::INT64). Additionally, it improves the error message in the Postgres server to suggest explicit casting when a parameter type is unknown. I have no feedback to provide as no review comments were present.
sunng87
changed the title
evenyag
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#8050
What's changed and what's your intention?
We have a sql rewrite rule that transform
$1::int4toarrow_cast($1, "Int32"). This patch fixes inference for these cases.PR Checklist
Please convert it to a draft if some of the following conditions are not met.