chore: use into_parts for owned record batches columns in mito2#8023
Draft
lyang24 wants to merge 1 commit intoGreptimeTeam:mainfrom
Draft
chore: use into_parts for owned record batches columns in mito2#8023lyang24 wants to merge 1 commit intoGreptimeTeam:mainfrom
lyang24 wants to merge 1 commit intoGreptimeTeam:mainfrom
Conversation
Signed-off-by: lyang24 <lanqingy93@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of RecordBatch objects across several files, including compat.rs, parquet.rs, and flat_format.rs. The changes replace the pattern of cloning columns and accessing schemas separately with the into_parts() method, which decomposes the batch into its constituent components. This refactoring likely improves efficiency by avoiding unnecessary clones. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
avoids one extra Vec allocation
PR Checklist
Please convert it to a draft if some of the following conditions are not met.