chore: avoid reparsing partition expr in mito2 reader#8022
Draft
lyang24 wants to merge 1 commit intoGreptimeTeam:mainfrom
Draft
chore: avoid reparsing partition expr in mito2 reader#8022lyang24 wants to merge 1 commit intoGreptimeTeam:mainfrom
lyang24 wants to merge 1 commit intoGreptimeTeam:mainfrom
Conversation
Signed-off-by: lyang24 <lanqingy93@gmail.com>
56de6b0 to
bf474b8
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ParquetReaderBuilder in src/mito2/src/sst/parquet/reader.rs by lifting the computation of region partition expressions out of the build_partition_filter method. The method signature is updated to accept these values as arguments, which are now passed from the caller where they were already being determined. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
in the read path there might be a opportunity to save a call on
get region_partition_exprwhich link toparse_partition_exprwith some json work.PR Checklist
Please convert it to a draft if some of the following conditions are not met.