chore: backport pr 5634 to release/v0.12-internal#8017
Draft
fengys1996 wants to merge 1 commit intoGreptimeTeam:release/v0.12-internalfrom
Draft
chore: backport pr 5634 to release/v0.12-internal#8017fengys1996 wants to merge 1 commit intoGreptimeTeam:release/v0.12-internalfrom
fengys1996 wants to merge 1 commit intoGreptimeTeam:release/v0.12-internalfrom
Conversation
…GreptimeTeam#5634) * fix: other col alias to time index column handle * test: update sqlness * chore: per review * test: more sqlness * test: mv some to optimizer folder * fix: resolve alias properly * fix: also retain old name * chore: remove wrong comment * chore: fix sqlness * test: standalone/dist more projection diff
github-actions
Bot
added
size/M
docs-not-required
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the windowed sort optimizer to correctly handle aliased sort expressions by introducing a mechanism to resolve column aliases for the time index during plan traversal. The feedback identifies several critical improvements: the alias_map should be local to each projection to prevent resolve_alias logic should be simplified to only include columns explicitly projected. Additionally, the unit tests need to be updated to reflect these logic corrections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.