Open
Conversation
305abc0 to
3ceef25
Compare
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the greptime.v1.meta.DdlTaskRequest protobuf API with two new DDL task variants to support workflows around dropped tables (restoring a dropped table and purging dropped-table metadata/data), and regenerates the Rust/Java/C++ bindings accordingly.
Changes:
- Add
UndropTableTaskandPurgeDroppedTableTaskmessage types toproto/greptime/v1/meta/ddl.proto. - Extend
DdlTaskRequest.taskoneof withundrop_table_task(tag 19) andpurge_dropped_table_task(tag 20). - Regenerate Rust (
prost), Java, and C++ protobuf outputs to include the new message types and oneof variants.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/greptime/v1/meta/ddl.proto | Defines the new task messages and wires them into DdlTaskRequest’s oneof. |
| src/generated/greptime.v1.meta.rs | Updates Rust generated structs and oneof enum to include the new tasks. |
| java/src/main/java/greptime/v1/meta/Ddl.java | Updates Java generated protobuf classes for the new messages/oneof cases. |
| c++/greptime/v1/meta/ddl.pb.h | Updates C++ generated headers for new message types and oneof accessors. |
| c++/greptime/v1/meta/ddl.pb.cc | Updates C++ generated implementation (descriptors, parsing/serialization, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add shared DDL expression messages for undrop and purge dropped table operations so meta DDL tasks follow the existing task wrapper pattern across generated bindings. Files: - `proto/greptime/v1/ddl.proto` - `proto/greptime/v1/meta/ddl.proto` - generated bindings Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
Restore direct catalog/schema/table fields on dropped table meta DDL tasks instead of wrapping shared DDL expressions. Files: - `proto/greptime/v1/ddl.proto` - `proto/greptime/v1/meta/ddl.proto` - generated bindings Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR extends the metasrv protobuf DDL task API for dropped-table lifecycle operations.
UndropTableTasktogreptime.v1.meta.DdlTaskRequestwith directcatalog_name,schema_name,table_name, and requiredtable_idfields.PurgeDroppedTableTasktogreptime.v1.meta.DdlTaskRequestwith directcatalog_name,schema_name,table_name, and optionaltable_idfields.DdlTaskRequest.taskwithundrop_table_tasktag19andpurge_dropped_table_tasktag20.Compatibility notes:
19and20.greptime.v1.DdlRequestexpressions.Checklist