services: add missing type annotations#1202
Merged
ryneeverett merged 3 commits intoGothenburgBitFactory:developfrom Apr 27, 2026
Merged
services: add missing type annotations#1202ryneeverett merged 3 commits intoGothenburgBitFactory:developfrom
ryneeverett merged 3 commits intoGothenburgBitFactory:developfrom
Conversation
Add return type and argument annotations across all services to satisfy the ANN ruff rules, which are now enforced on the full bugwarrior/ package. Also fixes a latent bug in NextcloudDeckService.get_owner, which treated a NextcloudDeckIssue as a subscriptable dict (TypeError at runtime when only_if_assigned was configured), and adds a regression test.
ryneeverett
reviewed
Apr 24, 2026
4d4abbe to
e0eeb9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add return type and argument annotations across all services to satisfy the ANN ruff rules, which are now enforced on the full bugwarrior/ package.
Clientinheritance from anyServicesubclass. Since thisClientclass only has a single staticmethod, and nothing else, we callClient.json_responsesdirectly instead. Services that subclassClientalready use it an attribute rather than a parent class, so this change adds consistency between all services__init__parameters for allServicesubclasses (usingconfigandmain_config), as they are required anyway, for easier typing.