Switched to using registry to build datasource/resource maps#17056
Switched to using registry to build datasource/resource maps#17056melinath wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
a43ce25 to
f303175
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…s before registry usage
This can be removed in a follow-up PR. The problem is that whatever func the diff-processor uses needs to be available in both provider versions (and registry isn't the source of truth until after this change)
These are copied from the downstream.
368caa9 to
8b5b1b2
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 6293 Click here to see the affected service packages
Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
We may want to allow a bit of a soak period before moving forward with this change.
Separately, this will have EAP impact.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.