Skip to content

Switched to using registry to build datasource/resource maps#17056

Open
melinath wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
melinath:use-registry-directly-for-schemas
Open

Switched to using registry to build datasource/resource maps#17056
melinath wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
melinath:use-registry-directly-for-schemas

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented Apr 9, 2026

We may want to allow a bit of a soak period before moving forward with this change.

Separately, this will have EAP impact.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@melinath melinath force-pushed the use-registry-directly-for-schemas branch from a43ce25 to f303175 Compare April 9, 2026 20:42
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

This can be removed in a follow-up PR. The problem is that whatever func the diff-processor uses needs to be available in both provider versions (and registry isn't the source of truth until after this change)
These are copied from the downstream.
@melinath melinath force-pushed the use-registry-directly-for-schemas branch from 368caa9 to 8b5b1b2 Compare April 13, 2026 20:42
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 212 insertions(+), 2120 deletions(-))
google-beta provider: Diff ( 7 files changed, 224 insertions(+), 2308 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 225 insertions(+), 234 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6293
Passed tests: 5629
Skipped tests: 650
Affected tests: 14

Click here to see the affected service packages

All service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_policy_iam_policy
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample
  • TestAccArtifactRegistryRepository_cleanup
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withAutopilotResourceManagerTags
  • TestAccDataSourceGoogleBackupDRManagementServer_basic
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants