Skip to content

Promote google_dataform_folder to GA#17027

Draft
sdsilva1 wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
sdsilva1:folders-ga
Draft

Promote google_dataform_folder to GA#17027
sdsilva1 wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
sdsilva1:folders-ga

Conversation

@sdsilva1
Copy link
Copy Markdown
Contributor

@sdsilva1 sdsilva1 commented Apr 8, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 8, 2026
@c2thorn c2thorn self-requested a review April 9, 2026 15:08
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@modular-magician modular-magician added service/dataform and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 9, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1080 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 3 files changed, 5 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 15 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 216 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataformFolder_dataformFolderBasicExample
  • TestAccDataformFolder_dataformFolderFullExample
  • TestAccDataformFolder_update

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataform

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@sdsilva1 sdsilva1 closed this Apr 9, 2026
@sdsilva1 sdsilva1 reopened this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/dataform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants