Skip to content

ECU CAN Migration#392

Merged
SlowThomas merged 19 commits intoGrandCanMigrationfrom
ECU_CAN_Migration
Apr 3, 2026
Merged

ECU CAN Migration#392
SlowThomas merged 19 commits intoGrandCanMigrationfrom
ECU_CAN_Migration

Conversation

@SlowThomas
Copy link
Copy Markdown
Contributor

@SlowThomas SlowThomas commented Apr 3, 2026 •
edited
Loading

ECU CAN Migration

Problem and Scope

Part of the Grand CAN Migration

Description

CAN Migration

Gotchas and Limitations

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

running ./build/HOOTLTest/ECU/StateTicksTest

Larger Impact

Must-do.

Additional Context and Ticket

#390

@SlowThomas @kzwicker @khoulihan27
Control-F
63f7204 
Co-authored-by: kzwicker <kzwicker@users.noreply.github.com>
Co-authored-by: khoulihan27 <khoulihan27@users.noreply.github.com>
@SlowThomas SlowThomas requested a review from dchansen06 as a code owner April 3, 2026 04:06
@SlowThomas SlowThomas marked this pull request as draft April 3, 2026 04:07
@SlowThomas SlowThomas added Documentation Improvements or additions to documentation Enhancement New feature or request 1 URGENT Urgent issue that needs a quick action and resolution Big Fry Something that is complex and/or large Sensors Something involved with or related to sensors Peripheral Related to or involving a peripheral including abstractions Boards Related to or involving any physical boards labels Apr 3, 2026
@SlowThomas
Copy link
Copy Markdown
Contributor Author

SlowThomas commented Apr 3, 2026 •
edited
Loading

I think we should try to solve the missing ADC steering wheel data issue in another branch.

Therefore, I am stubbing the GRCAN_ECU_ANALOG_DATA_MSG.steering_angle_signal with value 0 in StateTicks.c where this message is sent.

Our priority now should be to merge CAN migration to main fast.

@SlowThomas SlowThomas marked this pull request as ready for review April 3, 2026 17:57
@SlowThomas SlowThomas merged commit e5c2274 into GrandCanMigration Apr 3, 2026
33 checks passed
@SlowThomas SlowThomas deleted the ECU_CAN_Migration branch April 3, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchansen06 dchansen06 Awaiting requested review from dchansen06 dchansen06 is a code owner

Assignees

@SlowThomas SlowThomas

@kzwicker kzwicker

@khoulihan27 khoulihan27

Labels

1 URGENT Urgent issue that needs a quick action and resolution Big Fry Something that is complex and/or large Boards Related to or involving any physical boards Documentation Improvements or additions to documentation Enhancement New feature or request Peripheral Related to or involving a peripheral including abstractions Sensors Something involved with or related to sensors

Projects

None yet

Milestone

GR26 - Firmware Feature Freeze

Development

Successfully merging this pull request may close these issues.

3 participants

@SlowThomas @kzwicker @khoulihan27