NeoPixel Peripheral Memory Safety Improvements#380
Draft
dchansen06 wants to merge 10 commits intomainfrom
Draft
Conversation
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
dchansen06
added
Documentation
dchansen06
requested review from
Shrav816 and
TurtleTest2
and removed request for
TurtleTest2
Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
Change warning to error for undefined `GR_NEOPIXEL_MAX_LEDS` Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
Contributor
Author
|
Potentially currently broken -- May also be a hardware issue, see Discord
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeoPixel Memory Safety
Problem and Scope
VLAs can cause stack overflows
Malloc is generally unnecessary
Description
Setup a inclusion-defined array for the color to bit mapping conversion
Gotchas and Limitations
Still does not do the conversion once transmitting starts which uses more memory but is faster
Testing
Testing Details
Requires human testing
Larger Impact
Less likely to run out of memory unexpectedly
Additional Context and Ticket
Resolves #362