Remove most NHCoreMod liquid declarations#1684
Merged
Nikolay-Sitnikov merged 12 commits intomasterfrom Apr 15, 2026
Merged
Conversation
Nikolay-Sitnikov
added
the
refactor
danyadev
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required PR: GTNewHorizons/GT5-Unofficial#6292
These liquids had no reason to exist as blocks & buckets, they didn't work as intended, and they rely on YamCore, which I am trying to remove.
I have left Concrete behind as-is because Iguana Tinker Tweaks requires that there be a fluid block for its buckets, I have a clever idea for what the fluid could do, and I also want to try to unify it with GregTech's
wet.concrete.