Skip to content

🤖 Bug fix for real attributes in parallel socket input (glvis -a) #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tzanio wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

🤖 Bug fix for real attributes in parallel socket input (glvis -a) #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9105f5b
Bug fix for glvis -a
tzanio Mar 11, 2026
466bc47
Swapped the order of save_coloring and keep_attr for consistency
tzanio Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions glvis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,13 @@ class Session
public:
Session(bool fix_elem_orient,
bool save_coloring,
bool keep_attr,
string plot_caption,
bool headless)
{
win.data_state.fix_elem_orient = fix_elem_orient;
win.data_state.save_coloring = save_coloring;
win.data_state.keep_attr = keep_attr;
win.plot_caption = plot_caption;
win.headless = headless;
}
Expand Down Expand Up @@ -157,7 +159,8 @@ class Session
};

void GLVisServer(int portnum, bool save_stream, bool fix_elem_orient,
bool save_coloring, string plot_caption, bool headless = false)
bool save_coloring, bool keep_attr, string plot_caption,
bool headless = false)
{
std::vector<Session> current_sessions;
string data_type;
Expand Down Expand Up @@ -307,7 +310,8 @@ void GLVisServer(int portnum, bool save_stream, bool fix_elem_orient,
while (1);
}

Session new_session(fix_elem_orient, save_coloring, plot_caption, headless);
Session new_session(fix_elem_orient, save_coloring,
keep_attr, plot_caption, headless);

constexpr int tmp_filename_size = 50;
char tmp_file[tmp_filename_size];
Expand Down Expand Up @@ -693,6 +697,7 @@ int main (int argc, char *argv[])
std::thread serverThread{GLVisServer, portnum, save_stream,
win.data_state.fix_elem_orient,
win.data_state.save_coloring,
win.data_state.keep_attr,
win.plot_caption, win.headless};

// Start message loop in main thread
Expand Down
Loading