Draft
Conversation
its-saeed
reviewed
Feb 12, 2026
| ) -> TokenStream { | ||
| let resolved_logs = resolve_logs(logged_types); | ||
| let log_id_log_formatter_pairs = generate_log_id_log_formatter_pairs(&resolved_logs); | ||
| println!("{:#?}", log_id_log_formatter_pairs); |
Contributor
There was a problem hiding this comment.
I think we should remove these debug prints.
its-saeed
reviewed
Feb 12, 2026
| ::fuels::core::codec::LogFormatter::new_log::<#resolved_type>() | ||
| } | ||
| }; | ||
| println!("{:#?}", resolved_type); |
Contributor
There was a problem hiding this comment.
Same as the previous one
its-saeed
reviewed
Feb 12, 2026
| .expect("abigen generation failed") | ||
| .into() | ||
| .into(); | ||
| println!("{}", code); |
Contributor
There was a problem hiding this comment.
This change should be reverted.
its-saeed
reviewed
Feb 12, 2026
| assert!(!Token::String("a".into()).is_exact_size_abi()); | ||
| } | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
the test name and body don't follow our testing rules.
its-saeed
reviewed
Feb 12, 2026
| } | ||
|
|
||
| // #[test] | ||
| // fn enum_token() { |
Contributor
There was a problem hiding this comment.
do we want to have this test or remove it? I think commented test is not acceptable.
its-saeed
requested changes
Feb 12, 2026
Dentosal
reviewed
Feb 12, 2026
| eth-keystore = "0.5.0" | ||
| flate2 = { version = "1.0", default-features = false } | ||
| fuel-abi-types = "0.15.3" | ||
| fuel-abi-types = { path = "../sway/fuel-abi-types/", version = "0.13.0" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Summary
Breaking Changes
Checklist