Skip to content

(cherrypick) Rollback unsuccessful preconfs in the mempool (#3264) #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MitchTurner wants to merge 2 commits into from
Closed

(cherrypick) Rollback unsuccessful preconfs in the mempool (#3264) #3275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a8560a
Rollback unsuccessful preconfs in the mempool (#3264)
Dentosal Apr 16, 2026
2413d4c
fix changelog and compilation
MitchTurner Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/fixed/3275.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rollback stale preconfirmations in the mempool when the canonical block at that height omits the preconfirmed transactions, restoring spent inputs and removing dependent transactions.
9 changes: 2 additions & 7 deletions crates/services/txpool_v2/src/pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,7 @@ where
else {
// Invariant violation. Panic in tests, log in production.
debug_assert!(false, "Storage data not found for the transaction");
tracing::warn!(
"Storage data not found for the transaction during `remove_transaction`."
);
tracing::warn!("Storage data not found for the transaction during.");
Copy link
Copy Markdown

@cursor cursor Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truncated log message ends with dangling "during."

Low Severity

The warning message "Storage data not found for the transaction during." is grammatically incomplete — "during" is a preposition left without an object. The original message referenced `remove_transaction` after "during", which was accidentally removed instead of being kept or the entire trailing clause being dropped.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 78a204c. Configure here.

continue
};
self.extracted_outputs
Expand All @@ -516,10 +514,7 @@ where
false,
"Dependent storage data not found for the transaction"
);
tracing::warn!(
"Dependent storage data not found for \
the transaction during `remove_transaction`."
);
tracing::warn!("Dependent storage data not found for the transaction.");
continue
};

Expand Down
Loading