refactor: migrate ServerSideSDKKeys to FC#7003
Draft
talissoncosta wants to merge 3 commits intomainfrom
Draft
Conversation
Migrate ServerSideSDKKeys from Flux class components to functional components with RTK Query hooks, split into smaller focused components: - CreateServerSideKeyModal: modal for creating new keys - ServerSideKeyRow: individual key row rendering - ServerSideSDKKeys: main component using RTK Query hooks This fixes FLAGSMITH-FRONTEND-4FX where ProjectStore.getEnvironment() could return undefined and crash the modal render. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Create the new SDKKeysPage within the pages/sdk-keys feature folder, following the domain-driven folder pattern used by other features (e.g. pages/features/, pages/organisation-settings/). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wire up feature flag in the existing SDKKeysPage entry point to switch between the legacy Flux-based implementation and the new RTK Query version. When the flag is off, behaviour is unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
the
front-end
talissoncosta
changed the title
talissoncosta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7002
Migrate
ServerSideSDKKeys.jsfrom a Flux class component to functional components with RTK Query, behind a feature flag (rtk_server_side_sdk_keys).pages/sdk-keys/following existing domain-driven patternsServerSideSDKKeys,CreateServerSideKeyModal,ServerSideKeyRowProjectStore.getEnvironment()withuseGetEnvironmentsQuery(fixes Sentry FLAGSMITH-FRONTEND-4FX)getStore().dispatch()with RTK Query hooksServerSideSDKKeys.jspreserved untouched — feature flag toggles atSDKKeysPagelevelHow did you test this code?
🤖 Generated with Claude Code