changed mode numbers for pong and surround#397
Open
benblack769 wants to merge 1 commit intomasterfrom
Open
Conversation
Collaborator
|
@weepingwillowben do you have any sense of how aligned other modes are with their manual, i.e., 1-indexed with the proper indices? |
Contributor
Author
|
@JesseFarebro A few were indexed in more bizarre manners, for example Surround's modes currently start at -1. Some of those were fixed by #365. Then there are a few environments that do have modes in ALE, but not in the game manual, such as double dunk. |
JesseFarebro
force-pushed
the
master
branch
2 times, most recently
from
1e67fe1 to
8f3bc3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the surround and pong game modes to align with the manual, as per discussion here #366.