Skip to content

feat: graph encode/decode + iterator attr access#381

Merged
AviAvni merged 1 commit intomainfrom
graph-encode-decode
Apr 14, 2026
Merged

feat: graph encode/decode + iterator attr access#381
AviAvni merged 1 commit intomainfrom
graph-encode-decode

Conversation

@AviAvni
Copy link
Copy Markdown
Contributor

@AviAvni AviAvni commented Apr 14, 2026

Summary

  • Add encode_with_range() and Decode<19> to AttributeStore for RDB serialization
  • Add encode_payload() to Graph for chunked RDB encoding of nodes, edges, matrices
  • Improve capacity growth in create_nodes/create_relationships for effects replay
  • Change get_*_all_attrs_by_id to return impl Iterator (avoids Arc clone)
  • Adapt reply.rs to work with iterator return type

Part of splitting #359 into smaller reviewable PRs.

Test plan

  • cargo test -p graph passes
  • pytest tests/test_e2e.py -vv passes

- Add encode_with_range() and Decode<19> to AttributeStore for RDB serialization
- Add encode_payload() to Graph for chunked RDB encoding
- Improve capacity growth in create_nodes/create_relationships for effects replay
- Change get_*_all_attrs_by_id to return impl Iterator (avoid Arc<Vec> clone)
- Adapt reply.rs to collect iterator before use
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@AviAvni has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 49 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 49 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cc2cd8b-406a-46f0-9e29-507d474b776c

📥 Commits

Reviewing files that changed from the base of the PR and between 6c1e146 and b1a0f25.

📒 Files selected for processing (3)
  • graph/src/graph/attribute_store.rs
  • graph/src/graph/graph.rs
  • src/reply.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch graph-encode-decode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 13.73802% with 270 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.50%. Comparing base (6c1e146) to head (b1a0f25).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
graph/src/graph/graph.rs 12.93% 202 Missing ⚠️
graph/src/graph/attribute_store.rs 11.68% 68 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   83.04%   82.50%   -0.54%     
==========================================
  Files         110      110              
  Lines       29400    29621     +221     
==========================================
+ Hits        24414    24439      +25     
- Misses       4986     5182     +196     
Flag Coverage Δ
fuzz 40.85% <5.82%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AviAvni AviAvni merged commit 0858052 into main Apr 14, 2026
14 of 16 checks passed
@AviAvni AviAvni deleted the graph-encode-decode branch April 14, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant