Skip to content

feat: attribute import, temporal properties, SET fix#379

Merged
AviAvni merged 2 commits into
mainfrom
pending-attrs-split
Apr 14, 2026
Merged

feat: attribute import, temporal properties, SET fix#379
AviAvni merged 2 commits into
mainfrom
pending-attrs-split

Conversation

@AviAvni
Copy link
Copy Markdown
Contributor

@AviAvni AviAvni commented Apr 14, 2026

Summary

  • Add import_attrs() to AttributeStore for bulk importing entity attributes (used by RDB decoder)
  • Add import_node_attrs() / import_relationship_attrs() to Graph
  • Allow temporal types (Datetime, Date, Time, Duration) in is_valid_property validation
  • Fix SET on relationships that exist in pending state

Context

Part of splitting #359 (RDB serialization) into smaller reviewable PRs. This PR extracts attribute import helpers and two bug fixes that are independent of the larger serialization changes.

Test plan

  • cargo test -p graph passes
  • Existing e2e tests pass (pytest tests/test_e2e.py -vv)

- Add import_attrs() to AttributeStore for bulk importing entity attributes
- Add import_node_attrs()/import_relationship_attrs() to Graph
- Allow temporal types (Datetime, Date, Time, Duration) in is_valid_property
- Fix SET on relationships that exist in pending state
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@AviAvni has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 40 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e016066-857e-4c97-983f-5698744e71cc

📥 Commits

Reviewing files that changed from the base of the PR and between 2aef6e3 and 272f8a9.

📒 Files selected for processing (4)
  • graph/src/graph/attribute_store.rs
  • graph/src/graph/graph.rs
  • graph/src/runtime/ops/set.rs
  • graph/src/runtime/pending.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pending-attrs-split

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AviAvni AviAvni merged commit 6c1e146 into main Apr 14, 2026
14 checks passed
@AviAvni AviAvni deleted the pending-attrs-split branch April 14, 2026 13:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.02%. Comparing base (2aef6e3) to head (272f8a9).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
graph/src/graph/attribute_store.rs 0.00% 19 Missing ⚠️
graph/src/graph/graph.rs 0.00% 12 Missing ⚠️
graph/src/runtime/ops/set.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   83.16%   83.02%   -0.14%     
==========================================
  Files         109      110       +1     
  Lines       29327    29400      +73     
==========================================
+ Hits        24389    24410      +21     
- Misses       4938     4990      +52     
Flag Coverage Δ
fuzz 41.31% <2.94%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant