Skip to content

Fine ABL stats#1809

Draft
mbkuhn wants to merge 17 commits intoExawind:mainfrom
mbkuhn:fine_abl_stats
Draft

Fine ABL stats#1809
mbkuhn wants to merge 17 commits intoExawind:mainfrom
mbkuhn:fine_abl_stats

Conversation

@mbkuhn
Copy link
Copy Markdown
Contributor

@mbkuhn mbkuhn commented Dec 12, 2025

Summary

Path laid out for this upgrade

  • add input parameter to FieldPlaneAveragingFine that can limit the "finest level" to compute averages on
  • replace FieldPlaneAveraging with FieldPlaneAveragingFine
  • pass regression tests with "finest level" set to 0 in all of the places that used to feature FieldPlaneAveraging
  • update second order, third order moment calculations to be suited to finer levels (add level masking, interpolation)
  • add unit tests for second order, third order moment calculations on finer levels

Next tasks should probably be moved to a follow-on PR

  • update instances with "finest level" set to 0 to use finer levels, either by default or by user input (including ABLStats)
  • add new regression or unit test for new capability

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number: closes #1790, closes #1041

@mbkuhn
Copy link
Copy Markdown
Contributor Author

mbkuhn commented Dec 12, 2025

something is off with the ghost cells in differences between the two implementations

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Feb 21, 2026
@mbkuhn mbkuhn reopened this Mar 16, 2026
@mbkuhn
Copy link
Copy Markdown
Contributor Author

mbkuhn commented Mar 18, 2026

regression tests look good. lots of "fails" on abl cases but the diffs are small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Feature: ABL statistics on level >0 Feature request: ABL statistics on level >0

2 participants