splicescript: Turn on bitcoin addresses in splice script#8991
Open
ddustin wants to merge 4 commits intoElementsProject:masterfrom
Open
splicescript: Turn on bitcoin addresses in splice script#8991ddustin wants to merge 4 commits intoElementsProject:masterfrom
ddustin wants to merge 4 commits intoElementsProject:masterfrom
Conversation
This new test tests sending to a static amount in a bitcoin address inside splice script.
If we’re aborting a script attempt and that abort fails (for example if the connection is lost midway), we were leaving the callback payload `abort_pkg` attached to the plugin. This fix releases the `abort_pkg` when the abort fails.
Some bugs were existing in the bitcoin addr handling, `strcmp`’s result was handled backwards. The “Cannot fund from bitcoin address” check was also inverted, checking `in_sat` when it was meant to be checking `out_sat`. This value meaning sats going “in” to the action or “out” of the action. Also I moved the bitcoin addr handling into its own function, and had it occur later in the process. In paticular we needed it to happen *after* ppm calculations were complete to support dynamic amounts on the bitcoin address.
And also enable the tests for bitcoin addresses Changelog-Added: Added the ability to `spliceout` to a bitcoin address directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some work to enable bitcoin address support in splice script, with automatically empowers
spliceoutto receive an address as a destination. This (IMO super cool) feature allows people to pay onchain bitcoin addresses from their lightning balance.While we were, we spotted a rare corner case involving a small memleak and fixed it.
We also fixed a few issues with how bitcoin addresses were handled in splice script.
Then we enabled bitcoin addresses in splice script and turned on the tests.
Super excited for this one!