[RFC] common: add BOLT12 payer proof support#8990
Open
vincenzopalazzo wants to merge 1 commit intoElementsProject:masterfrom
Open
[RFC] common: add BOLT12 payer proof support#8990vincenzopalazzo wants to merge 1 commit intoElementsProject:masterfrom
vincenzopalazzo wants to merge 1 commit intoElementsProject:masterfrom
Conversation
vincenzopalazzo
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vincenzopalazzo
force-pushed
the
codex/payer-proof-1295
branch
from
a7db989 to
d7a2239
Compare
Add common-layer payer proof encode, decode, and verification support for the `lnp` BOLT12 proof format. Expose payer proof decoding through `decode`, `bolt12-cli`, and type guessing in the offers plugin. Add vector-backed payer proof tests covering the published payer-proof corpus, including note-bearing proofs and selective disclosure of an odd experimental TLV. Changelog-None
vincenzopalazzo
force-pushed
the
codex/payer-proof-1295
branch
from
d7a2239 to
8be6d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lnpBOLT12 proof formatdecode,bolt12-cli, and type guessing in the offers pluginTesting
make -j1 common/test/run-payer_proof./common/test/run-payer_proofmake -j1 plugins/test/run-decode_guess_type devtools/bolt12-cli plugins/offers./plugins/test/run-decode_guess_typejq -r '.vectors[] | select(.expected.valid) | [.name, .expected.proof_bech32] | @tsv' /tmp/payer-proof-test-vectors/test_vectors.json | while IFS=$'\t' read -r name proof; do ./devtools/bolt12-cli decode "$proof" >/dev/null || { echo "$name"; exit 1; }; donemake -j1 common/test/run-bolt12_merkle common/test/run-bolt12-format-string-test./common/test/run-bolt12_merkle./common/test/run-bolt12-format-string-testChangelog-None