Skip to content

Show Nym mixnet warning in stake/unstake/claim scenes#5995

Merged
j0ntz merged 2 commits intodevelopfrom
jon/feat/earn-nym-mixnet-warning
Apr 24, 2026
Merged

Show Nym mixnet warning in stake/unstake/claim scenes#5995
j0ntz merged 2 commits intodevelopfrom
jon/feat/earn-nym-mixnet-warning

Conversation

@j0ntz
Copy link
Copy Markdown
Contributor

@j0ntz j0ntz commented Apr 15, 2026

image

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana task

Asana: Earn - Nym Mixnet warning

Adds the existing Nym mixnet warning (already used in the Send scene) to the Stake, Unstake, and Claim Rewards scenes so users are informed that staking transactions may take longer to broadcast when Nym mixnet is active.

  • Gates the warning on isNymActive derived from wallet.currencyConfig.userSettings (same pattern as SendScene2).
  • Reuses lstrings.settings_nym_mixnet_warning_title / settings_nym_mixnet_warning_body via AlertCardUi4 wrapped in EdgeAnim.
  • Warning renders above the slider, matching the Send scene placement.
  • StakeModifyScene handles stake, unstake, and claim modes via route.params.modification, so a single insertion covers all three scenes.
  • Also converts StakeModifySceneComponent to React.FC<Props> to clear a pre-existing lint warning in the same file (separate commit).

Note

Low Risk
Low risk UI-only change that conditionally renders an additional warning card based on userSettings.networkPrivacy; no transaction construction or staking logic changes.

Overview
Adds a conditional Nym Mixnet warning to StakeModifyScene so users see a delay notice when performing stake, unstake, or claim rewards while Nym network privacy is enabled.

Implements isNymActive by watching wallet.currencyConfig.userSettings and renders the existing localized warning copy via AlertCardUi4 (animated with EdgeAnim) above the confirmation slider, with minor spacing tweaks. Updates CHANGELOG.md accordingly.

Reviewed by Cursor Bugbot for commit b21d0a9. Bugbot is set up for automated code reviews on this repo. Configure here.

@j0ntz j0ntz force-pushed the jon/feat/earn-nym-mixnet-warning branch 2 times, most recently from 2f6398a to 2018c48 Compare April 15, 2026 23:04
@j0ntz j0ntz force-pushed the jon/feat/earn-nym-mixnet-warning branch from 2018c48 to b21d0a9 Compare April 23, 2026 23:59
@j0ntz j0ntz merged commit 2158041 into develop Apr 24, 2026
2 of 4 checks passed
@j0ntz j0ntz deleted the jon/feat/earn-nym-mixnet-warning branch April 24, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants