Skip to content

SDL Android: Bump to 2.32.10 and preparations for SDL3#3522

Merged
carstene1ns merged 6 commits intoEasyRPG:masterfrom
Ghabry:android-sdl
Mar 17, 2026
Merged

SDL Android: Bump to 2.32.10 and preparations for SDL3#3522
carstene1ns merged 6 commits intoEasyRPG:masterfrom
Ghabry:android-sdl

Conversation

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Feb 23, 2026

SDL2 is almost EOL so this patch was really hard to apply ;)

btw unrelated: There is something broken in libogc, Wii builder gives errors

@Ghabry Ghabry added this to the 0.8.2 milestone Feb 23, 2026
@Ghabry Ghabry added the Android label Feb 23, 2026
@carstene1ns
Copy link
Member

Yeah, it is in low maintenance mode for some time now.
We can likely migrate to SDL3 without loosing much old devices, since play store requirements are higher than SDL's.
Also with SDL3 we can likely just ship the AAR prefab instead of compiling it.

@carstene1ns
Copy link
Member

The gradle wrapper/plugin should be updated:

This Android Gradle plugin (8.7.3) was tested up to compileSdk = 35.

You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 36.

Also seems we have a layout error in the gamebrowser:

GameBrowserActivity.java:251: Error: When using `setHasFixedSize() in an RecyclerView, wrap_content cannot be used as a value for size in the scrolling direction. [InvalidSetHasFixedSize from androidx.recyclerview]
        gamesGridRecyclerView.setHasFixedSize(true);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "InvalidSetHasFixedSize":
   When a RecyclerView uses setHasFixedSize(...) you cannot use wrap_content
   for  size in the scrolling direction.

Ghabry added 4 commits March 16, 2026 17:47
The lowest supported SDK is now 23 (Android 6.0)
…syRpgPlayerActivity

This required a different implementation for the back handling because AppCompatActivity cannot be used anymore
@Ghabry Ghabry changed the title SDL Android: Bump to 2.32.10 SDL Android: Bump to 2.32.10 and preparations for SDL3 Mar 16, 2026
@Ghabry
Copy link
Member Author

Ghabry commented Mar 16, 2026

Bumping all the gradle + deps required me to change the SDK to Android 6 (which should be still acceptable by now xD)

Refactored the code to make the SDL3 migration easier: Removed all our edits from SDLActivity and replaced them with overloaded methods and other trickery (stupid new back API...)

Though I'm still against moving to SDL3: I tested it and it randomly crashes when exiting a game, usually when its the second game started but not always. SDL2 version is stable in this regard. 🤷

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oldest device I can test is on Android 9, not sure how many with 6 are still out there...

@Ghabry
Copy link
Member Author

Ghabry commented Mar 17, 2026

updated to latest gradle wrapper jar.

Android 9 is also the oldest device around for testing here.

I used an emulator to test Android 6, Android 10, 15 and 16.

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my device.

@carstene1ns carstene1ns merged commit 8acd2e1 into EasyRPG:master Mar 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants