Skip to content

Add support for parsing Taffy style types from string#929

Merged
nicoburns merged 6 commits intoDioxusLabs:mainfrom
nicoburns:parse
Mar 17, 2026
Merged

Add support for parsing Taffy style types from string#929
nicoburns merged 6 commits intoDioxusLabs:mainfrom
nicoburns:parse

Conversation

@nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Mar 16, 2026

Objective

Context

Notes

  • This bumps MSRV to 1.71 because cssparser with default features depends on syn which requires 1.71. We could technically avoid this as we're not using default features. But it doesn't seem worth the effort given that 1.71 is from July 2023?
  • This adds an (optional) dependency on cssparser which is MPL
  • cssparser no longer has a hard dependency on proc-macro infra

Todo

Future work

  • Add a FromStr implementation for taffy::Style (that supports parsing a semicolon-delimited CSS style block)

@nicoburns nicoburns added the enhancement New feature or request label Mar 16, 2026
@nicoburns nicoburns force-pushed the parse branch 4 times, most recently from 3c217c1 to 01f3435 Compare March 17, 2026 14:21
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
@nicoburns nicoburns merged commit 70341c9 into DioxusLabs:main Mar 17, 2026
31 checks passed
@nicoburns
Copy link
Collaborator Author

@SimonSapin I already merged this, but this is effectively a revival of your earlier PR (#460). And your review (especially around correct cssparser usage) would be welcomed.

@SimonSapin
Copy link
Contributor

This is nice to see! I can answer specific questions if you have them but sorry, it looks like a full review of a PR this size would take more time than I have right now.

@nicoburns
Copy link
Collaborator Author

No worries! Just wanted to give you the chance to input if you wanted to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants