Add support for parsing Taffy style types from string#929
Merged
nicoburns merged 6 commits intoDioxusLabs:mainfrom Mar 17, 2026
Merged
Add support for parsing Taffy style types from string#929nicoburns merged 6 commits intoDioxusLabs:mainfrom
nicoburns merged 6 commits intoDioxusLabs:mainfrom
Conversation
3c217c1 to
01f3435
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Collaborator
Author
|
@SimonSapin I already merged this, but this is effectively a revival of your earlier PR (#460). And your review (especially around correct |
Contributor
|
This is nice to see! I can answer specific questions if you have them but sorry, it looks like a full review of a PR this size would take more time than I have right now. |
Collaborator
Author
|
No worries! Just wanted to give you the chance to input if you wanted to :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Stylefrom (and serialize to?) CSS syntax #440Context
Notes
cssparserwith default features depends onsynwhich requires 1.71. We could technically avoid this as we're not using default features. But it doesn't seem worth the effort given that 1.71 is from July 2023?cssparserwhich is MPLcssparserno longer has a hard dependency on proc-macro infraTodo
from_keywords!macro from [WIP] Parse Style from and serialize to CSS syntax #460Work out whether the(for now it's private, we can make it public later if desired).FromCsstrait (and thus thecssparserdependency) should be publicFuture work
FromStrimplementation fortaffy::Style(that supports parsing a semicolon-delimited CSS style block)