284 refactor pulse generator severpy to inherit from abstractinstrumentserver#285
Open
Relm-Arrowny wants to merge 71 commits intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 31 +1
Lines 774 831 +57
=========================================
+ Hits 774 831 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
…4-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
…4-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
…ub.com:DiamondLightSource/sm-bluesky into 280-baseserver-abstract-class-for-tcp-services
…4-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
…4-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
…4-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
…4-refactor-pulse_generator_severpy-to-inherit-from-abstractinstrumentserver
Base automatically changed from
280-baseserver-abstract-class-for-tcp-services
to
main
March 30, 2026 15:23
…nerator_severpy-to-inherit-from-abstractinstrumentserver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284 part of #274
#280 is the base class and should be reviewed before this
Instructions to reviewer on how to test:
Checks for reviewer