Skip to content

DataGrid - Pager - Show correct pageIndex when virtualScrolling is enabled on pageSize change #33412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tucchhaa wants to merge 2 commits into
base: 26_1
Choose a base branch
from
+39 −0
Open

DataGrid - Pager - Show correct pageIndex when virtualScrolling is enabled on pageSize change #33412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
664a129
fix
Tucchhaa Apr 27, 2026
29f7c02
implement test
Tucchhaa Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,41 @@ test('Page index should not reset when scrolling while the grid is being refresh
height: 440,
}));

test('Pager info should show page 1 of 1 after changing pageSize to \'all\' with virtual scrolling', async (t) => {
const dataGrid = new DataGrid('#container');
const pager = dataGrid.getPager();

await t
.click(pager.getNavPage('5').element)
.expect(pager.getNavPage('5').selected)
.ok()
.expect(pager.getInfoText().textContent)
.eql('Page 5 of 10 (50 items)');

await t
.click(pager.getPageSize(1).element)
.expect(pager.getInfoText().textContent)
.eql('Page 1 of 1 (50 items)');
}).before(async () => createWidget('dxDataGrid', {
dataSource: [...new Array(50).keys()].map((i) => ({ id: i })),
keyExpr: 'id',
showBorders: true,
scrolling: {
mode: 'virtual',
},
paging: {
pageSize: 5,
},
pager: {
visible: true,
allowedPageSizes: [5, 'all'],
showPageSizeSelector: true,
showInfo: true,
showNavigationButtons: true,
},
height: 400,
}));

test('No error should occur if dataSource is not defined and pageIndex is promise chained (T1256070)', async (t) => {
const dataGrid = new DataGrid('#container');

Expand Down
4 changes: 4 additions & 0 deletions packages/devextreme/js/__internal/grids/grid_core/pager/m_pager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ const PAGER_CLASS = 'pager';
export const MAX_PAGES_COUNT = 10;

const getPageIndex = function (dataController) {
Copy link
Copy Markdown
Contributor Author

@Tucchhaa Tucchhaa Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is used to get visible index of the current page, that is passed to pager so it could display it.

If in pager the pageSize 'all' is selected, then dataController.pageSize() == 0, and so there's only one page.

if (dataController.pageSize() === 0) {
return dataController.pageCount();
}

// eslint-disable-next-line radix
return 1 + (parseInt(dataController.pageIndex()) || 0);
};
Expand Down
Loading