Skip to content

feat: Link to project using name and version #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WIStudent wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Link to project using name and version #1425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bad0e7
feat: Link to project using name and version
WIStudent Jan 19, 2026
46a1d85
Apply suggestions from code review
WIStudent Mar 10, 2026
059926f
Reencode name and version when redirecting
WIStudent Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/router/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,42 @@ function configRoutes() {
permission: 'VIEW_PORTFOLIO',
},
},
{
path: 'projects/:name/:version/*',
name: 'Project By Name and Version',
beforeEnter: (to, from, next) => {
const searchParams = new URLSearchParams({
name: to.params.name,
version: to.params.version,
Comment on lines +220 to +222
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project names and versions may contain special characters that need URL encoding. The current implementation doesn't decode these parameters before sending them to the API. If a project name contains special characters (e.g., spaces, slashes), the URL parameters extracted from to.params will already be decoded by Vue Router, but this should be verified. Additionally, consider validating that the name and version parameters don't contain path separators or other invalid characters that could cause routing issues.

Suggested change
const searchParams = new URLSearchParams({
name: to.params.name,
version: to.params.version,
const decodeParam = (value) => {
if (typeof value !== 'string') {
return '';
}
try {
return decodeURIComponent(value);
} catch (e) {
// If decoding fails (malformed escape sequences), fall back to the original value
return value;
}
};
const isValidSegment = (value) =>
typeof value === 'string' && !/[\\/]/.test(value);
const name = decodeParam(to.params.name);
const version = decodeParam(to.params.version);
if (!isValidSegment(name) || !isValidSegment(version)) {
next({
name: '404',
replace: true,
});
return;
}
const searchParams = new URLSearchParams({
name,
version,

Copilot uses AI. Check for mistakes.
Copy link
Author

@WIStudent WIStudent Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces and slashes are not a problem if encoded properly, vue-router will decode this /projects/Test%20%2FABC/0.0.1/ to name Test /ABC and URLSearchParams will encode it correctly.

});
router.app.axios
.get(
`${router.app.$api.BASE_URL}/${router.app.$api.URL_PROJECT_LOOKUP}?${searchParams}`,
)
.then((result) => {
const trailingPathSegments = to.params.pathMatch
? `/${to.params.pathMatch}`
: '';
next({
path: `projects/${result.data.uuid}${trailingPathSegments}`,
replace: true,
});
})
.catch(() => {
next({
name: '404',
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query parameters from the original URL are not preserved during the redirect. If the original URL contains query parameters (e.g., for filtering or sorting), they will be lost. Consider preserving them by including query: to.query in the next() object alongside the path.

Suggested change
path: `projects/${result.data.uuid}${trailingPathSegments}`,
replace: true,
});
})
.catch(() => {
next({
name: '404',
path: `projects/${result.data.uuid}${trailingPathSegments}`,
query: to.query,
replace: true,
});
})
.catch(() => {
next({
name: '404',
query: to.query,

Copilot uses AI. Check for mistakes.
Copy link
Author

@WIStudent WIStudent Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, neither the 404 page nor the project page seem to use query parameters.

Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL hash fragments are not preserved during the redirect. If the original URL contains a hash (e.g., for in-page navigation or state), it will be lost. Consider preserving the hash by including hash: to.hash in the next() object alongside the path.

Suggested change
path: `projects/${result.data.uuid}${trailingPathSegments}`,
replace: true,
});
})
.catch(() => {
next({
name: '404',
path: `projects/${result.data.uuid}${trailingPathSegments}`,
hash: to.hash,
replace: true,
});
})
.catch(() => {
next({
name: '404',
hash: to.hash,

Copilot uses AI. Check for mistakes.
Copy link
Author

@WIStudent WIStudent Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, neither the 404 page nor the project page seem to use hash fragments.

replace: true,
});
Comment on lines +237 to +241
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error handling catches all errors uniformly, but different error types should potentially be handled differently. For example, a 404 (not found) is different from a 401 (unauthorized) or 500 (server error). Consider checking the error response status to provide more appropriate error handling, especially for authorization errors which might need different treatment than simple "not found" scenarios.

Suggested change
.catch(() => {
next({
name: '404',
replace: true,
});
.catch((error) => {
const status = error && error.response && error.response.status;
if (status === 404) {
next({
name: '404',
replace: true,
});
} else if (status === 401 || status === 403) {
next({
name: 'Login',
replace: true,
});
} else {
// Cancel navigation on unexpected errors to avoid misreporting them as "not found"
next(false);
}

Copilot uses AI. Check for mistakes.
Copy link
Author

@WIStudent WIStudent Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, both the project page and the lookup require the VIEW_PORTFOLIO permission. If the user doesn't have it, the global forEach navigation guard will redirect to the login page and the beforeEnter navigation guard in the Project By Name and Version route will not be called.

});
},
meta: {
permission: 'VIEW_PORTFOLIO',
},
},
{
path: 'projects/:name/:version',
redirect: 'projects/:name/:version/',
},
{
path: 'components',
name: 'Component Lookup',
Expand Down
1 change: 1 addition & 0 deletions src/shared/api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"URL_POLICY_VIOLATION": "api/v1/violation",
"URL_POLICY_VIOLATION_ANALYSIS": "api/v1/violation/analysis",
"URL_PROJECT": "api/v1/project",
"URL_PROJECT_LOOKUP": "api/v1/project/lookup",
"URL_REPOSITORY": "api/v1/repository",
"URL_SEARCH": "api/v1/search",
"URL_SERVICE": "api/v1/service",
Expand Down
Loading