Skip to content

feat(activemq): add dataflows.yaml asset#23560

Closed
bgoldberg122 wants to merge 2 commits intomasterfrom
bgoldberg122/activemq-dataflows
Closed

feat(activemq): add dataflows.yaml asset#23560
bgoldberg122 wants to merge 2 commits intomasterfrom
bgoldberg122/activemq-dataflows

Conversation

@bgoldberg122
Copy link
Copy Markdown
Contributor

Summary

  • Add missing assets/dataflows.yaml to the activemq integration
  • Defines activemq-broker-metrics stream for JMX-collected broker, queue, and Artemis metrics
  • Defines activemq-logs stream for activemq.log and audit.log via the source:activemq pipeline

Test plan

  • Verify dataflows.yaml schema is valid against the Publishing Platform spec
  • Confirm stream IDs follow <app_id>-<data-category> convention

🤖 Generated with Claude Code

- Add missing dataflows.yaml to activemq assets directory
- Define activemq-broker-metrics stream for JMX-collected metrics
- Define activemq-logs stream for activemq.log and audit.log

Rationale: The activemq integration had dashboards, monitors, logs, and saved_views but was missing the dataflows asset required for the Publishing Platform tile to describe data collection streams.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91216278a8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread activemq/assets/dataflows.yaml Outdated
- id: activemq-broker-metrics
always_on: true
- id: activemq-logs
always_on: true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark activemq logs stream as optional

The new activemq-logs stream is marked always_on: true, but this integration’s own setup docs say log collection is disabled by default and only works after explicitly enabling logs and adding log config (activemq/README.md lines 52-59). Keeping this as always-on misrepresents when the logs dataflow is actually available and can skew downstream cataloging/eligibility logic for installations that only collect metrics.

Useful? React with 👍 / 👎.

- Rename activemq-broker-metrics to activemq-metrics (covers both classic
  and Artemis metric families, which share the same toggle behavior)
- Add required data_type and direction fields per dataflows schema
- Set activemq-logs always_on: false since log collection is opt-in

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 1, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@bgoldberg122 bgoldberg122 deleted the bgoldberg122/activemq-dataflows branch May 1, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant