feat(activemq): add dataflows.yaml asset#23560
Conversation
- Add missing dataflows.yaml to activemq assets directory - Define activemq-broker-metrics stream for JMX-collected metrics - Define activemq-logs stream for activemq.log and audit.log Rationale: The activemq integration had dashboards, monitors, logs, and saved_views but was missing the dataflows asset required for the Publishing Platform tile to describe data collection streams.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91216278a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - id: activemq-broker-metrics | ||
| always_on: true | ||
| - id: activemq-logs | ||
| always_on: true |
There was a problem hiding this comment.
Mark activemq logs stream as optional
The new activemq-logs stream is marked always_on: true, but this integration’s own setup docs say log collection is disabled by default and only works after explicitly enabling logs and adding log config (activemq/README.md lines 52-59). Keeping this as always-on misrepresents when the logs dataflow is actually available and can skew downstream cataloging/eligibility logic for installations that only collect metrics.
Useful? React with 👍 / 👎.
- Rename activemq-broker-metrics to activemq-metrics (covers both classic and Artemis metric families, which share the same toggle behavior) - Add required data_type and direction fields per dataflows schema - Set activemq-logs always_on: false since log collection is opt-in Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Validation ReportAll 20 validations passed. Show details
|
Summary
assets/dataflows.yamlto the activemq integrationactivemq-broker-metricsstream for JMX-collected broker, queue, and Artemis metricsactivemq-logsstream foractivemq.logandaudit.logvia thesource:activemqpipelineTest plan
dataflows.yamlschema is valid against the Publishing Platform spec<app_id>-<data-category>convention🤖 Generated with Claude Code