[sqlserver] Add legacy schema collection integration coverage#23550
Draft
lu-zhengda wants to merge 3 commits intomasterfrom
Draft
[sqlserver] Add legacy schema collection integration coverage#23550lu-zhengda wants to merge 3 commits intomasterfrom
lu-zhengda wants to merge 3 commits intomasterfrom
Conversation
806e570 to
f99cedc
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
Contributor
|
✨ Fix all issues with BitsAI or with Cursor
|
6022c47 to
55fe11f
Compare
f99cedc to
43e3700
Compare
55fe11f to
317aecc
Compare
43e3700 to
cf5e555
Compare
317aecc to
e0233ef
Compare
cf5e555 to
ca88c70
Compare
e0233ef to
8fd9b3e
Compare
ca88c70 to
916a084
Compare
8fd9b3e to
beaf61d
Compare
916a084 to
bb26e71
Compare
beaf61d to
0023dae
Compare
bb26e71 to
a2b3e1a
Compare
Contributor
Validation ReportAll 20 validations passed. Show details
|
9968f22 to
475d23d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds integration coverage for the legacy SQL Server schema collection path by forcing
STATIC_INFO_MAJOR_VERSIONto 13 while runningSQLServerSchemaCollector.collect_schemas()against the real SQL Server fixture database.The test captures the emitted DBM schema metadata and asserts that the legacy path returns real table details, including columns, indexes, partition counts, and foreign keys.
Why
The CI matrix does not include a pre-2017 SQL Server instance, so the legacy schema path needs explicit forced-path coverage to catch crashes or regressions in the real collector flow.