apply security format refs to template configuration YAMLs#23540
Draft
apply security format refs to template configuration YAMLs#23540
Conversation
Contributor
Validation Report
Run Passed validations (18)
|
|
✨ Fix all issues with BitsAI or with Cursor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret: truewithformats: ["secret"]in template YAMLs (http,jmx,tls,pdh_legacy,perf_counters) — the fleet-sync-worker converter now infers secret semantics from the format refjava_optionsformat key:formats: ["java_jvm_options"]→formats: ["jvm"](the converter's exception map mapsjvm→java_jvm_options.json)formats: ["path"]to TLS cert/CA cert fields inhttpandtlstemplatesformats: ["tag"]totagsitems in thetagstemplate andkubernetes_state_corespecformats: ["url"]toprometheus_urlinopenmetrics_legacy_baseTest plan
ddev validate configto verify no template regressionsSequencing
Depends on [dd-source PR B] merging first.
This PR removes
secret: truefrom template YAMLs; thex-display.secret: trueandwriteOnly: truein generated schemas are restored by the converter inference added in the dd-source PR.