Conversation
Co-authored-by: nubtron <49084+nubtron@users.noreply.github.com>
|
I can only run on private repositories. |
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
Validation ReportAll 20 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c0bb94c38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
|
✨ Fix all issues with BitsAI or with Cursor
|
What does this PR do?
Adds quieter validation PR reporting for
ddev validate allby marking validation report comments with hidden status metadata, skipping duplicate success comments, and allowing PRs labeledci/skip-validation-commentsto suppress validation report comments entirely.Motivation
Validation reports should remain useful when they require attention or show recovery, but repeated successful validation comments add noise to active PRs. A label-based suppression option also gives maintainers an explicit way to keep PR conversations quiet while validations continue to run.
Changes
ci/skip-validation-commentslabel detection from the pull request event payload.Testing/Validation
ruff check --fix ddev/src/ddev/cli/validate/all/__init__.py ddev/src/ddev/cli/validate/all/github.py ddev/src/ddev/cli/validate/all/orchestrator.py ddev/tests/cli/validate/all/test_command.py ddev/tests/cli/validate/all/test_github.py ddev/tests/cli/validate/all/test_orchestrator.pyddev --no-interactive test ddev -- tests/cli/validate/all/test_github.py tests/cli/validate/all/test_orchestrator.py tests/cli/validate/all/test_command.pyddev release changelog new fixed ddev -m "Allow PRs to suppress validation report comments with a label.", but it could not run in this detached worktree becauseorigin/masteris unavailable.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is mergedPR by Bits - View session in Datadog
Comment @DataDog to request changes