Fix bentoml tests: remove patch override of mock_http_response, add METRICS assertions

[mwdd146980]

Motivation

Two test correctness bugs in bentoml/tests/test_unit.py, found during the requests→httpx migration audit (PR #22710).

Both tests call mock_http_response(file_path=...) and then immediately override BentomlCheck.http with patch(). The key insight: OpenMetricsScraper has its own RequestsWrapper created independently in __init__, so patching BentomlCheck.http never affected the scraper. Both the scraper and the health endpoint checks ultimately call requests.Session.get, which mock_http_response already patches.

test_bentoml_mock_metrics

• The inner patch(BentomlCheck.http) block is dead weight. mock_http_response already serves health endpoint calls.
• assert mock_http.get.call_count == 2 is an implementation detail assertion that breaks if endpoints are added or removed.

test_bentoml_mock_valid_endpoint_invalid_health

• Achieves URL routing by accident via two independent mock layers that happen to target different code paths.
• No assertions on OpenMetrics metrics, so a regression in the primary check output would go undetected.

Approach

• test_bentoml_mock_metrics: Remove the inner patch() block and assert call_count == 2.
• test_bentoml_mock_valid_endpoint_invalid_health: Replace with mock_http_response_per_endpoint for explicit URL routing. MockResponse(status_code=500).raise_for_status() raises HTTPError naturally. Add METRICS assertions.

Verification

• Added METRICS assertions to test_bentoml_mock_valid_endpoint_invalid_health before refactoring; confirmed they passed with the old mock (scraper was already emitting metrics correctly).
• ddev test -fs bentoml clean, 3/3 pass.

[dd-octo-sts]

Validation Report

All 20 validations passed.

Show details

Validation	Description	Status
agent-reqs	Verify check versions match the Agent requirements file	✅
ci	Validate CI configuration and Codecov settings	✅
codeowners	Validate every integration has a CODEOWNERS entry	✅
config	Validate default configuration files against spec.yaml	✅
dep	Verify dependency pins are consistent and Agent-compatible	✅
http	Validate integrations use the HTTP wrapper correctly	✅
imports	Validate check imports do not use deprecated modules	✅
integration-style	Validate check code style conventions	✅
jmx-metrics	Validate JMX metrics definition files and config	✅
labeler	Validate PR labeler config matches integration directories	✅
legacy-signature	Validate no integration uses the legacy Agent check signature	✅
license-headers	Validate Python files have proper license headers	✅
licenses	Validate third-party license attribution list	✅
metadata	Validate metadata.csv metric definitions	✅
models	Validate configuration data models match spec.yaml	✅
openmetrics	Validate OpenMetrics integrations disable the metric limit	✅
package	Validate Python package metadata and naming	✅
readmes	Validate README files have required sections	✅
saved-views	Validate saved view JSON file structure and fields	✅
version	Validate version consistency between package and changelog	✅

View full run

[datadog-datadog-prod-us1]

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 94.79% (+7.72%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 227485d | Docs | Datadog PR Page | Give us feedback!}