Skip to content

lexer: handle multiline comment after keyword#89

Merged
lu-zhengda merged 1 commit intoDataDog:mainfrom
blotus:ident-multilinecomment-fix
Mar 27, 2026
Merged

lexer: handle multiline comment after keyword#89
lu-zhengda merged 1 commit intoDataDog:mainfrom
blotus:ident-multilinecomment-fix

Conversation

@blotus
Copy link
Copy Markdown
Contributor

@blotus blotus commented Mar 10, 2026

Hello,

While testing your (excellent) library, we found a corner case in which SQL keywords were not properly detected when followed directly by a multiline comment.

Before this change, the query select/**/*/**/from/**/events would get tokenized as:

select/
*
*
/*/**/
from/
*
*
/
events

Note the / from the comment being part of select.

With this change, it now gets parsed as:

select
/**/
*
/**/
from
/**/
events

@blotus blotus requested a review from a team as a code owner March 10, 2026 14:24
@lu-zhengda lu-zhengda merged commit 86709ed into DataDog:main Mar 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants