Updated the root-controller configuration in generate_session so that…#628
Open
bieryAtFnal wants to merge 1 commit intodevelopfrom
Open
Updated the root-controller configuration in generate_session so that…#628bieryAtFnal wants to merge 1 commit intodevelopfrom
bieryAtFnal wants to merge 1 commit intodevelopfrom
Conversation
… it uses the latest rccontroller service and has a specific opmon_conf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… it uses the latest rccontroller service and has a specified opmon_conf.
Description
This change is for v5.7.0...
While working on changes to integration test infrastructure, I noticed that the
pytestframework has been capturing (and not displaying to the user) a warning message from the configuration-generation step in the integration tests.That message was the following:
I believe that the cause for this warning message is that the configuration-generation for the root-controller in the
generation_sessionfunction ingenerate.pyneeded to be updated to match the current state of other parts of the code.Specifically, it needed to specify the
opmon_conffor the root-controller and it needed to use the latest rccontroller UID.This PR has these changes, and these changes avoid the warning message.
I believe that without these fixes, some or all of the default root-controller configuration that is provided in
daqsystemtest/config/daqsystemtest/ccm.data.xmlwas not being over-written with the update provided ingenerate_session.Here are suggested instructions for demonstrating the fix:
A follow-up note: I have draft changes to the integration test infrastructure to display warnings like this to users (so we don't go a long time without noticing problems like this one).
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)